Handles unloaded origin chain #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abtestingalpha
requested review from
bigboydiamonds,
nautsimon and
aureliusbtc
as code owners
WalkthroughThe changes primarily focus on enhancing the code's robustness by implementing optional chaining in two files. This update ensures that the code doesn't throw an error when certain properties are undefined, improving the overall stability of the application. Changes
Poem
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- packages/synapse-interface/components/StateManagedBridge/ToTokenListOverlay.tsx (1 hunks)
- packages/synapse-interface/utils/calculateEstimatedTransactionTime.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/synapse-interface/utils/calculateEstimatedTransactionTime.tsx
Additional comments: 1
packages/synapse-interface/components/StateManagedBridge/ToTokenListOverlay.tsx (1)
- 272-278: The use of optional chaining here is a good practice to prevent potential errors when
fromTokenis undefined. However, ensure that the functioncalculateEstimatedTransactionTimecan handle a potentialundefinedvalue fororiginTokenAddress.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1532 +/- ##
===================================================
- Coverage 51.57449% 51.23324% -0.34125%
===================================================
Files 372 362 -10
Lines 25532 24691 -841
Branches 281 283 +2
===================================================
- Hits 13168 12650 -518
+ Misses 11074 10813 -261
+ Partials 1290 1228 -62
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
3f542c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09b29942.sanguine.pages.dev |
| Branch Preview URL: | https://fe-fromtoken-fix.sanguine.pages.dev |
bigboydiamonds
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
ToTokenListOverlaycomponent to prevent crashes when certain data is unavailable.654c9c3d06e707e38488376ece9e9956a968fb4c: synapse-interface preview link